Conversation
pan-x-c
reviewed
Jan 8, 2026
yanxi-chen
reviewed
Jan 8, 2026
lingzhq
commented
Jan 8, 2026
Owner
Author
lingzhq
left a comment
lingzhq
left a comment
There was a problem hiding this comment.
Address all review comments: refactor configuration and python entrypoint.
lingzhq
commented
Jan 8, 2026
| ), | ||
| ) | ||
| for eval_taskset in config.buffer.explorer_input.eval_tasksets: | ||
| eval_taskset.workflow_args = workflow_args |
Owner
Author
There was a problem hiding this comment.
This change is required to pass workflow_args to eval_tasksets that are configured purely via YAML, similar to the logic on line 80. Otherwise, workflow_func and judge_func are not included in the Trinity config for evaluation.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope Version
[The version of AgentScope you are working on, e.g.
import agentscope; print(agentscope.__version__)]Description
[Please describe the background, purpose, changes made, and how to test this PR]
Checklist
Please check the following items before code is ready to be reviewed.
pre-commit run --all-filescommand